Route all trainer worker calls through the worker handle instead of Ray handles - #2175
Merged
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 4, 2026 14:17
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
August 6, 2026 03:47
27f7541 to
e14f7ad
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 6, 2026 03:47
897c0ec to
03a6a74
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
August 6, 2026 07:04
e14f7ad to
7b7cce2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 6, 2026 07:04
03a6a74 to
84a5ab9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
August 9, 2026 23:32
7b7cce2 to
d3ba846
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 9, 2026 23:32
84a5ab9 to
98c9464
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
August 10, 2026 00:44
d3ba846 to
ffedb2e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 10, 2026 00:44
98c9464 to
3f4bf39
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
August 10, 2026 06:02
ffedb2e to
68820b0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 10, 2026 06:02
3f4bf39 to
c240135
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
August 10, 2026 16:06
68820b0 to
9fdcfeb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 10, 2026 16:06
c240135 to
6e08c81
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
August 10, 2026 16:34
9fdcfeb to
48f9354
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
3 times, most recently
from
August 12, 2026 09:32
bb5a811 to
e10081d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
August 12, 2026 14:31
55732ed to
729b4fa
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
2 times, most recently
from
August 12, 2026 14:36
1a60d0a to
7d58d39
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
August 12, 2026 14:36
729b4fa to
1c226d4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
August 29, 2026 12:38
e7edc2a to
b0a590c
Compare
fzyzcjy
commented
Aug 30, 2026
fzyzcjy
left a comment
Collaborator
Author
There was a problem hiding this comment.
The change preserves existing Ray call and worker-death semantics while migrating all production WorkerInfo consumers. No correctness regression survives at deliver-1, and no deliver-2 repair needs to be moved forward.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
2 times, most recently
from
September 1, 2026 10:03
91d50b3 to
fb3a636
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
2 times, most recently
from
September 1, 2026 10:35
d507b90 to
339f254
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
September 1, 2026 10:35
fb3a636 to
2871564
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
September 1, 2026 14:33
339f254 to
5a80da2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
September 1, 2026 14:33
2871564 to
1ba2c26
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
September 2, 2026 03:00
5a80da2 to
f918831
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
2 times, most recently
from
September 3, 2026 06:02
ef4d23d to
9892b5a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
September 3, 2026 06:21
251ba90 to
8d38fcb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
September 3, 2026 06:21
9892b5a to
627408c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
September 3, 2026 06:33
8d38fcb to
8068e75
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
September 3, 2026 06:33
627408c to
625adf8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
September 3, 2026 07:53
8068e75 to
2a77de9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
September 3, 2026 07:53
625adf8 to
029cdd1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
September 3, 2026 10:52
2a77de9 to
b4c38b3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
2 times, most recently
from
September 3, 2026 23:27
7257449 to
e661f60
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
September 4, 2026 00:54
a5f26d8 to
9cc2c0d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
September 4, 2026 00:54
e661f60 to
8decd95
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
September 4, 2026 03:28
9cc2c0d to
dcdea92
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
September 4, 2026 03:28
8decd95 to
a842c51
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-159
branch
from
September 4, 2026 06:55
dcdea92 to
a677bb1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-160
branch
from
September 4, 2026 06:56
a842c51 to
dacbb9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837